{scarthgap} Append ${ros_prefix} to recipes #1213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As appending ${ros_prefix} to CMAKE_INSTALL_PREFIX,
these recipes had issues in installation.
Signed-off-by: Mark Choi <[email protected]>
license string was appended in bbappend file was not properly processed. I remove license string in th setup.py when creating setup.py intentionally on the bbappend file. dashingsoft/pyarmor#1602 https://stackoverflow.com/questions/77523055/missingdynamic-license-defined-outside-of-pyproject-toml-is-ignored Signed-off-by: Mark Choi <[email protected]>
BDS --> BSD Signed-off-by: Mark Choi <[email protected]>
fixed-compile-error-uint64t.patch is no longer valid. it was fixed from 2.55.1. Signed-off-by: Mark Choi <[email protected]>
Fixed following error | sed: can't read /home/bchoi/nvidia-yocto-bsp/bchoi-build/tmp/work/armv8a-oe4t-linux/ament-download/0.0.5-1/image/usr/share/ament_download/cmake/download_checkmd5.py: No such file or directory Signed-off-by: Mark Choi <[email protected]>
- error log :
tmp/work/armv8a-oe4t-linux/ceres-solver/2.2.0/recipe-sysroot/usr/include/eigen3/Eigen/src/MetisSupport/MetisSupport.h:112:34: error: cannot convert 'int*' to 'idx_t*' {aka 'long int*'}
This error was from version upgrade from package version 2.1.0 to 2.2.0.
CMakeLists.txt is introduced new option, EIGENSPARSE and it is turned on by default which also enable EIGENMETIS option to use eigen3 metis.
Signed-off-by: Mark Choi <[email protected]>
liblighting_lib is removed and replaced liblighting_node. Signed-off-by: Mark Choi <[email protected]>
ERROR: Nothing PROVIDES 'sdformat' ROS_UNRESOLVED_DEP-sdformat12 = "sdformat" --> ROS_UNRESOLVED_DEP-sdformat12 = "sdformat12" Signed-off-by: Mark Choi <[email protected]>
libtinyxml2 was built with meson and static lib. But other recipes refence it with cmake file not .pc file as a dependency. So, it is needed to build with cmake generating target cmake files for them. Signed-off-by: Mark Choi <[email protected]>
/home/bchoi/nvidia-yocto-bsp/bchoi-build/tmp/work/armv8a-oe4t-linux/moveit-core/2.5.5-1/git/collision_detection_fcl/src/collision_common.cpp:527:40: err 11 527 | !std::static_pointer_cast<const fcl::OcTreed>(o1->collisionGeometry())->getRoot()) || moveit-core fail to build because fcl failed to find_package for octomap. cmake, not ros_cmake, is not aware of ros_prefix. Signed-off-by: Mark Choi <[email protected]>
robwoolley
force-pushed
the
scarthgap-next
branch
from
ee3109e
to
2c28501
Compare
robwoolley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As appending ${ros_prefix} to CMAKE_INSTALL_PREFIX, these recipes had issues in installation.