-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an OdometryWithAcceleration message #87
base: jade-devel
Are you sure you want to change the base?
Conversation
Where was |
In the Odometry Interface section: |
@tfoote is this going to be merged soon? This is an interesting approach that we probably want to explore on MAVROS. |
I would like to merge this soon. I think it would be rushed to push this out before the melodic release as I'd like to cross reference it with the update for REP 145 from #101 though looking at that now. It's really for the raw measurements, whereas the reported odometry should be fully fused. But since this is a pure addtion we can add it out of cycle as well as can backport it so I'm not going to push to get it into melodic before the release next week. @TSC21 If you are thinking about picking it up. I'd love it if you would copy the message and try it out locally to get feedback on the structure. And if it suits your needs that would be great to know that the message in this format is working. |
@tfoote this is of most interest for us developers as we are aiming to push it further for interfacing ROS with PX4 (if you are interested, have a look of what is being done in PX4/PX4-Autopilot#9301). This would probably be tested, in a first stage, on simulation, and then move forward with its support both ROS and PX4 estimators. PX4 Pro would probably be the best autopilot to be in the vanguard for testing and pushing this forward. |
Thanks for the link. I've subscribed to that ticket. I hope to have some more support for a specific effort to push more standardized messages soon. |
@tfoote any updates regarding this? |
We are also using an identical message for quite a while since it's very useful: https://github.com/fzi-forschungszentrum-informatik/automated_driving_msgs/blob/master/msg/MotionState.msg I would recommend to also clarify the treatment of unknown/incomplete covariance information. Further, I'd suggest to keep the term I could provide a PR if you like. Edit: I also just saw a bug in line 9 of the new message, it should be |
I just fixed these issues in #146 |
As needed by REP 147 discussion: Pull request and discourse thread