Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deprecated message filter headers #94

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jul 15, 2024

Related with this PR ros2/message_filters#135

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
#include <message_filters/sync_policies/approximate_time.h>
#include <message_filters/synchronizer.h>
#include <message_filters/subscriber.hpp>
#include <message_filters/sync_policies/approximate_time.hpp>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR's CI seems to not like the ordering here.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from CursedRock17 July 18, 2024 20:42
@ahcorde
Copy link
Collaborator Author

ahcorde commented Jul 18, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link

@CursedRock17 CursedRock17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahcorde ahcorde merged commit a4a3ce4 into rolling Jul 19, 2024
1 of 4 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/message_filter_deprecated_c_headers branch July 19, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants