Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined search/list deps page #449

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from

Conversation

rkent
Copy link

@rkent rkent commented Nov 21, 2024

This adds a tabulator-based combined list and search page for system dependencies. Much of this is a copy of what we did with the package list page. This does not show this new page in the UI (like with package list), to view it you need to enter /search_deps/

It adds additional fields to deps, allow searching by upstream package name, platform, ROS package dependant, in addition to dep name and description. I'm not sure system dependency search needs all of this, but it was not difficult to add.

This removes the sharding from the search data for deps, which also affects the existing search page. The size still seems managable. It will eventually be smaller once we remove the old search pages, as there is a lot of extraneous information in the data and index that was used by the old search page, but is not needed by the new one.

Although largely copied from the new package search page, there are two new features here that I also intend to add to the package search: initial sort by search score, and an extensive help page.

Our power is out which affects my build farm, so I am unable to run a non-development build with this for demo, but I will do that as soon as the power is restored.

@rkent rkent force-pushed the 1-expand-deps-search-fields branch from 08e819d to 3e120e0 Compare November 21, 2024 18:13
@rkent
Copy link
Author

rkent commented Nov 21, 2024

Sorry for the revision, I discovered some unneeded code to remove.

Signed-off-by: R. Kent James <[email protected]>
@rkent rkent force-pushed the 1-expand-deps-search-fields branch from 3e120e0 to 6c9afa4 Compare November 21, 2024 20:27
@rkent
Copy link
Author

rkent commented Nov 21, 2024

Oops, sorry again for the redo, had to remove some spaces from blank lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant