Updates to layout/theming #118

MyNameIsCosmo · 2017-11-24T08:32:20Z

Initial changes to front page theming for better readability.
Added a "Recently Added" feature of 6 items below Featured Robot.
Sort listings alphabetically
Ribbon for robot category for easier category recognition

Fix syntax warning from Jekyll Move tags to bottom right of post, remove border Limit to 6 tags to show Description overflows to a scroll bar

MyNameIsCosmo · 2017-11-24T21:34:22Z

There's more updates coming.
I'll submit another pull request sometime tomorrow, and any desired features can be cherry-picked upstream.

tfoote

Thanks for these suggestions. I've commented on several of them that look good. You closed this and mentioned that you're looking at making some more suggested updates. Is that still pending?

tfoote · 2017-11-28T19:08:14Z

.gitignore

 _site
 node_modules
 _drafts
 localtest_config.yml
+
+# Temporary Files


These os/system specific things I recommend adding to your global git config instead of adding them to all projects.

tfoote · 2017-11-28T19:11:36Z

_includes/box-item.html

-          {% if post.title == site.featured_robot %}
-          <a href="{{ post.url | prepend: site.baseurl }}"><span>Featured</span></a>
-          {% endif %}
+          <a href="{{site.baseurl}}/category/{{post.main-class}}"><span>{{post.main-class}}</span>


We used to have this on all posts but the number of ribbons seemed overwhelming so we reduced their usage.

tfoote · 2017-11-28T19:15:56Z

_includes/box-item.html

        </span>
        <div class="box-body">
            <!-- <meta itemprop="datePublished" content="{{post.date | date_to_xmlschema }}">
            <time itemprop="datePublished" datetime="{{ post.date }}" class="date">{{ post.date | date_to_string }}</time> -->
+            {% if post.vendor %}
+            <span class="post-vendor">
+                {{ post.vendor }}


Adding a vendor is a great addition. I'd like to do this in a way that we can generate cross references for vendors with listings of their robots. This might want the ability to have a small vendor profile with a sentence, link, and logo.

I'm working on 2 forks for this repo:
sensors.ros.org - http://wiki.ros.org/Sensors to Jekyll GH-Pages
vendors.ros.org - List of contractors, distributors, educational, manufacturers, and vendors for ROS-related products and services

This would help organize and add to the collective knowledge of various companies, components, sensors, and robots in the ROS ecosystem.

What are your thoughts on this?

It would be great to capture that information. However I'm not sure that spreading it out over several domains makes sense. That seems like it will start to become a maintenance burden. We already have a Sensors category. If there are sensor specific templates we can relatively easily customize those for the category. And similarly for the vendors, they're going to be closely coupled to the robots here so separating them out would just significantly increase the likely hood of broken cross references. And for both I don't think we're at much risk of having colliding namespaces between any of these categories so I'm not worried about the URLs. We could push the vendors into a namespace lie /vendor/*.

tfoote · 2017-11-28T19:17:30Z

_includes/header-default.html

@@ -4,5 +4,20 @@ <h1 class="logo">
            <img style="height: 33px" src="/assets/img/ros_robots.png"/>
        </a>
    </h1>
+		<table id="topnav-table"> 
+      <tbody><tr> <td valign="middle">


This is definitely something we should add.

This seems to disappear when on small screens and overlaps when at itermediate widths:

It would be great to push it up above the site content like we do with the other sites instead of interleaving it.

Cross referencing #116

tfoote · 2017-11-28T19:19:58Z

index.html


+    <H2>Recently Added</H2>


I wasn't aware of the limit: option this opens up lots of new capabilities for the home page.

I'm testing this out and the limit doesn't seem to be rendering correctly with incorrect number and range of box items appearing. I think there's potentially an issue with the randomization logic for the main listing.

MyNameIsCosmo · 2017-11-28T21:20:40Z

Yep, still working on some updates. I have looked over your comments, and will make some amendments later today based on your feedback.

I ran into a problem with the Liquid SaSS converter.
Finally found my issue; still working on a slight workaround for the lighten() and darken() sass functions to properly color the borders based on the background color. Partly due to the version of some liquid packages installed in my docker container.

I updated the docker file to use the same version packages as GH-Pages.

Should be pushing some more updates tonight, and reopening this pull request.

MyNameIsCosmo · 2017-11-29T06:21:46Z

Ended up branching off the colors work, as I could not figure out the correct SaSS layout.
Attempts at using darken and lighten in scss did not bode well in initial tests.
I will alloc more time to some other GH issues when I get a chance.

Feel free to select which commits you'd like to see merged upstream.
Here's how the latest layout looks like:

Reopening this PR.

tfoote · 2017-11-29T20:54:26Z

_includes/box-item.html

-                  {% endif %}
-                </ul>
-                </div>
+            <div class="post-container-icon">


I merged the box reformat with adding the category link back.

tfoote · 2017-12-05T08:20:17Z

Thanks for all the contributions. I've merged many of them manually and ticketed a few of the remaining ones that I had some request for changes on. With the noteable conflicts, I'm going to close this PR. If you have more suggestions or want to revise some of the existing ones please open a new PR.

MyNameIsCosmo added 8 commits November 24, 2017 02:50

.gitignore with temp files and os generated files

80117d0

Sort robots alphabetically in "All" views

a5122b3

Add "Recently Added"

a02c599

Set ribbon to robot category

6b551b5

Vendor tag with turtlebot 3 example

6d88209

Reformat box items to be more readable

db5ae12

Add standard header to other ROS resources

cb6a107

fixes ros-infrastructure#116

Some more post reorganizing

43ff14c

Fix syntax warning from Jekyll Move tags to bottom right of post, remove border Limit to 6 tags to show Description overflows to a scroll bar

MyNameIsCosmo closed this Nov 24, 2017

Sync versions with latest GH pages versions

dea5ac7

tfoote reviewed Nov 28, 2017

View reviewed changes

MyNameIsCosmo reopened this Nov 29, 2017

tfoote reviewed Nov 29, 2017

View reviewed changes

tfoote added a commit that referenced this pull request Dec 5, 2017

Use the sorting technique from @MyNameIsCosmo in #118

395cfcc

tfoote added a commit that referenced this pull request Dec 5, 2017

Add recently added section from #118

a4b798c

tfoote closed this Dec 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to layout/theming #118

Updates to layout/theming #118

MyNameIsCosmo commented Nov 24, 2017 •

edited

Loading

MyNameIsCosmo commented Nov 24, 2017

tfoote left a comment

tfoote Nov 28, 2017

tfoote Nov 28, 2017

tfoote Nov 28, 2017

MyNameIsCosmo Nov 28, 2017 •

edited

Loading

tfoote Nov 28, 2017

tfoote Nov 28, 2017

tfoote Nov 29, 2017

tfoote Dec 5, 2017

tfoote Nov 28, 2017

tfoote Nov 29, 2017

MyNameIsCosmo commented Nov 28, 2017

MyNameIsCosmo commented Nov 29, 2017

tfoote Nov 29, 2017

tfoote commented Dec 5, 2017

Updates to layout/theming #118

Updates to layout/theming #118

Conversation

MyNameIsCosmo commented Nov 24, 2017 • edited Loading

MyNameIsCosmo commented Nov 24, 2017

tfoote left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MyNameIsCosmo Nov 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MyNameIsCosmo commented Nov 28, 2017

MyNameIsCosmo commented Nov 29, 2017

Choose a reason for hiding this comment

tfoote commented Dec 5, 2017

MyNameIsCosmo commented Nov 24, 2017 •

edited

Loading

MyNameIsCosmo Nov 28, 2017 •

edited

Loading