Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #70 (comment) :
It turns out that it was necessary also to implement a couple more operators, so the PR is ready but it is mostly open just to receive feedback, in particular:
estimateVelocity
continued to work exactly as it did with boost::math . For the time being I did not use any test library, if you have any preference I can migrate the test to your favored framework.abb::egm::wrapper::Quaternion
structure, but I had to introduce a small private class to contain internal quaternion operations. I intentionally hided this object from the public headers to avoid to maintain them in the future, let me know if this is ok.