Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dynamic reconfigure value to not set arbitrarily brightness, co… #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

awesomebytes
Copy link
Member

…ntrast, hue and saturation.

In order to avoid situations like: #92

@awesomebytes
Copy link
Member Author

@furushchev what do you think? I'd like a second opinion if you have a minute to spare.

@@ -23,6 +23,7 @@ gen.add("flip_horizontal", bool_t, LEVEL.NORMAL, "Flip image horizontally", Fals
gen.add("flip_vertical", bool_t, LEVEL.NORMAL, "Flip image vertically", False)
gen.add("width", int_t, LEVEL.RUNNING, "Target width", 0, 0, 10000)
gen.add("height", int_t, LEVEL.RUNNING, "Target height", 0, 0, 10000)
gen.add("set_camera_properties", bool_t, LEVEL.RUNNING, "Set the camera properties (brightness, contrast, hue, saturation)", False)
gen.add("brightness", double_t, LEVEL.RUNNING, "Target brightness", 0.5019607843137255, 0.0, 1.0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be better if it is "Target brightness (Available only when set_camera_properties is true)".
Same on the "contrast", "hue" and "saturation".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants