-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple roswtf plugin that checks the number of connected devices #80
Add a simple roswtf plugin that checks the number of connected devices #80
Conversation
572cefc
to
d3f7e15
Compare
286364f
to
3de8ff9
Compare
6b19b45
to
9f21af9
Compare
I scratch that. Because I need to have this working on Indigo as well, I just replaced the code with what works on Trusty without depending on a special library. Just tested on Trusty with 2 Xtions plugged in.
ROS buildfarm CI fails same as #57 (comment), which is ignorable (we'll have to disable it on the next release to rosdistro). |
3774de7
to
e4fc557
Compare
…es ROS Param server.
@mikeferguson Since you left a comment, which was very helpful, can you give another look? I summarized the result in #80 (comment) |
Packaging aspects LGTM -- I know nothing about the roswtf stuff. |
ROS buildfarm CI fails but can be ignored same as #55. On the next release I'll disable it. This has been tested on our weekly test and works fine. Merging once Travis CI passes but please open tickets for any issues. |
e9a7faa
to
506b0d0
Compare
ABI check failed only for Melodic https://travis-ci.org/ros-drivers/openni2_camera/jobs/405168671#L1587
Not sure what's the error in the output. Merging, but this needs a closer look before making a new release to Melodic. |
In some applications specific number of sensors are required to run as expected. This PR adds roswtf plugin to check the number of the sensors plugged in to the computer your application runs on.
Example: by plugging 2 sensors, the check fail if
openni2_num_sensors
is not changed (default=1).After setting
openni2_num_sensors
param with 2, no error occurs.