Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ex10: use gpio_command_controller #627

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

christophfroehlich
Copy link
Contributor

This changes the example_10 to use the gpio_command_controller proposed with ros-controls/ros2_controllers#1251

I also mentioned the /dynamic_joint_states topic from JSB.

Comment on lines +2 to +5
ros2_controllers:
type: git
url: https://github.com/ros-controls/ros2_controllers.git
version: gpio_controllers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ros2_controllers:
type: git
url: https://github.com/ros-controls/ros2_controllers.git
version: gpio_controllers

Comment on lines +2 to +5
ros2_controllers:
type: git
url: https://github.com/ros-controls/ros2_controllers.git
version: gpio_controllers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ros2_controllers:
type: git
url: https://github.com/ros-controls/ros2_controllers.git
version: gpio_controllers

Copy link

@Wiktor-99 Wiktor-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to delete entry of ros2_control_demo_example_10/GPIOController in the
ros2_control_demo_example_10.xml

example_10/doc/userdoc.rst Show resolved Hide resolved
example_10/doc/userdoc.rst Show resolved Hide resolved
Copy link

@Wiktor-99 Wiktor-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich
Copy link
Contributor Author

Let's wait for the next release of ros2_controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants