-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ex10: use gpio_command_controller
#627
base: master
Are you sure you want to change the base?
Conversation
ros2_controllers: | ||
type: git | ||
url: https://github.com/ros-controls/ros2_controllers.git | ||
version: gpio_controllers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ros2_controllers: | |
type: git | |
url: https://github.com/ros-controls/ros2_controllers.git | |
version: gpio_controllers |
ros2_controllers: | ||
type: git | ||
url: https://github.com/ros-controls/ros2_controllers.git | ||
version: gpio_controllers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ros2_controllers: | |
type: git | |
url: https://github.com/ros-controls/ros2_controllers.git | |
version: gpio_controllers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to delete entry of ros2_control_demo_example_10/GPIOController
in the
ros2_control_demo_example_10.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's wait for the next release of ros2_controllers. |
This changes the example_10 to use the gpio_command_controller proposed with ros-controls/ros2_controllers#1251
I also mentioned the /dynamic_joint_states topic from JSB.