Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gz-physics#283 to implement joint_states/effort feedback (backport #186) #432

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 28, 2024

Fixes joint_states/effort being zero for joints with <state_interface name="effort" /> in combination with joint_state_broadcaster/JointStateBroadcaster by using the JointTransmittedWrench component introduced by gazebosim/gz-physics#283.

The joint axis is hard coded to z. I did not yet look into reading out the actual <axis> of the joint and extracting the respective force/torque component of the wrench.


This is an automatic backport of pull request #186 done by Mergify.

(cherry picked from commit cc66e73)

# Conflicts:
#	gz_ros2_control/src/gz_system.cpp
@mergify mergify bot requested a review from ahcorde as a code owner October 28, 2024 09:02
@mergify mergify bot added the conflicts label Oct 28, 2024
Copy link
Contributor Author

mergify bot commented Oct 28, 2024

Cherry-pick of cc66e73 has failed:

On branch mergify/bp/iron/pr-186
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit cc66e73.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   gz_ros2_control/src/gz_system.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants