-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Gazebo Demo for Mecanum Drive Controller #358
base: iron
Are you sure you want to change the base?
Conversation
Updates: - Added a 4 wheeled mecanum wheel base cart demo to try out the mecanum drive controller. - Updated the documentation. - Added new folder named "mesh" under "gazebo_ros2_control_demos/urdf" for storing mesh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pratham-Pandey Thank you for your contribution. Do you mind to open the PR against or retarget this one to master
? then we can backport this to rest of distros.
I'm not completely against adding meshes for the model, Maybe we can keep roller.stl
and use a rectangle as the base ? What do you think ?
What does that means? This pull request is for ROS Iron and i feel it would be better to merge it with Iron branch. Can it be merged with Master Branch? I don't have much idea about git. I have this pull request as draft because the cart is not loading in Gazebo when relative path for mesh is used(using "package://"). It is working fine with absolute path, though. Do you have any idea how can I get it working with relative path?
Yes it is Good. But having mesh for roller is a must for the cart to behave like a holonomic drive cart. Apart from that, what is the downside of using mesh in this repo? The base mesh dose'nt look that bad 😆 |
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Pratham-Pandey I made same changes in this commit https://github.com/ros-controls/gazebo_ros2_control/tree/ahcorde/iron/mecanum
I didn't try the mecanum controller but the robot is there with the mecanum wheels. Do you mind to cherry-pick the commit and try again?
@ahcorde ok. I will open this PR for review once done. |
@ahcorde The controller is still working after your changes. I have opened the Pull Request. Question:
Let me know if any other changes are required. Thanks! |
|
This PR requires this controller ros-controls/ros2_controllers#512. PR is still open. |
The controller PR needs to be merged before this PR could be merged?
|
Yes, It's a requirement, otherwise the example will not work with the debian packages. |
@ahcorde the controller PR has been merged. Have made some changes in config and URDF of this PR. Let me know if any other changes are required and we could get this PR merged. |
@Pratham-Pandey be aware that iron is EOL and we won't release the mecanum controller or gazebo_ros2_control any more to iron. please rebase your PR to rolling/master branch, and we might backport it to humble if the controller will be merged into humble |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind to target rolling
?
To target rolling, I need to create a separate PR? |
no,you can rebase yours on top of master, force push, and change the target of the PR |
Added Holonomic Drive(Mecanum Wheel Based) Demo:
NOTE:
<mesh filename="package://gazebo_ros2_control_demos/urdf/mesh/holonomic_drive/roller.stl" scale="0.001 0.001 0.001"/>
<mesh filename="file:///home/Desktop/roller.stl" scale="0.001 0.001 0.001"/>