Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize antiwindup variable properly (backport #326) #328

Merged
merged 1 commit into from
May 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions gazebo_ros2_control/src/gazebo_system.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ control_toolbox::Pid GazeboSystem::extractPID(
double kd;
double max_integral_error;
double min_integral_error;
bool antiwindup;
bool antiwindup = false;

if (joint_info.parameters.find(prefix + "kp") != joint_info.parameters.end()) {
kp = std::stod(joint_info.parameters.at(prefix + "kp"));
Expand Down Expand Up @@ -199,8 +199,6 @@ control_toolbox::Pid GazeboSystem::extractPID(
{
antiwindup = true;
}
} else {
antiwindup = false;
}

RCLCPP_INFO_STREAM(
Expand Down