Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

31 featuretoggleguard throws error because of missing reflector #46

Merged

Conversation

rorteg
Copy link
Owner

@rorteg rorteg commented Sep 5, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:=

What is the current behavior?

Currently, E2E tests are configured as end-to-end tests, but these could be restructured as integration tests, improving speed and simplicity without the need to spin up a real server.

Issue Number: #31

What is the new behavior?

  • E2E tests were migrated to integration tests.
  • Jest configuration was updated to include integration tests and enable verbose output.
  • The e2e directory and related configurations were removed.
  • A new tests/integration directory was created to house the integration tests.
  • Added support for debugging configuration in VSCode.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR does not change any application functionality, focusing on improvements to the test structure and tool configuration.

- removed e2e folder and related configurations
- migrated tests to integration folder
- updated jest config to include integration tests
- added VSCode launch configuration for debugging
- fixed issue with jest verbose output

fixes #31
@rorteg rorteg requested review from renatops1991 and ran-j September 5, 2024 04:28
Copy link

github-actions bot commented Sep 5, 2024

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 92.36% (+15.78% 🔼) 133/144
🟡 Branches 73.91% (+12.66% 🔼) 51/69
🟢 Functions 90.48% (+15.9% 🔼) 38/42
🟢 Lines 94.22% (+3.37% 🔼) 212/225

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟢 src/feature-toggle-header-request.interceptor.ts 85.71% (+11.9% 🔼) 60% (-1.54% 🔻) 100% (+16.67% 🔼) 100%
🟢 src/entities/FeatureEntity.ts 90.91% (-1.4% 🔻) 100% 85.71% 100%
🟢 src/dataSources/feature-toggle-config.data-source.ts 100% (+23.81% 🔼) 66.67% (-15.69% 🔻) 100% (+16.67% 🔼) 100%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 5c559c2

@rorteg rorteg merged commit 2c0c827 into master Sep 5, 2024
2 checks passed
@rorteg rorteg deleted the 31-featuretoggleguard-throws-error-because-of-missing-reflector branch September 5, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant