Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polishing #87

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Polishing #87

wants to merge 8 commits into from

Conversation

adamhsparks
Copy link
Member

Fixes an internal function title format but more importantly, does away with an if...else... sequence by detecting the systems file separator using .Platform$file.sep by not needing to check for Windows or other OS.

@adamhsparks
Copy link
Member Author

Ok, .Platform$file.sep still returns "/" on Windows, but digging around in our own codebase, I found, normalizePath(dirname, winslash = "/"), which should accomplish what we need to do here.

@bozaah, since you found this "bug" with Windows, can you confirm that this works as intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bozaah bozaah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamhsparks @bozaah