Avoid using equality checks / %in% on class() #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
commented
Mar 17, 2024
| @@ -424,12 +424,12 @@ otp_parse_missing <- function(x){ | |||
|
|
|||
| otp_clean_input <- function(imp, imp_name) { | |||
| # For single point inputs | |||
| if (all(class(imp) == "numeric")) { | |||
| if (!is.matrix(imp) && is.double(imp)) { | |||
There was a problem hiding this comment.
this test looked to me like "non-matrix numeric vector", which matches the new test. CMIIW.
MichaelChirico
commented
Mar 17, 2024
| expect_true(nrow(r3) == 1) | ||
| expect_true("leg_elevation" %in% names(r3)) | ||
| expect_true(class(r3$leg_elevation) == "list") | ||
| expect_true(is.list(r3$leg_elevation)) |
There was a problem hiding this comment.
this could also be expect_type(., "list")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just started with the package so thought I'd try and contribute back some code quality fixes as a token of thanks.
Found with
lintr::class_equals_linter(). Some of the changes (noted in a comment) require more context than I have to execute completely correctly, so feedback welcome on things that need more fine-tuning.There are many other changes found with
lintr::lint_package(linters = lintr::all_linters()); many of them are stylistic but others have implications for correctness, too.