Bump minimum PHP requirement from 5.6 to 7.1 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump minimum PHP requirement from 5.6 to 7.1 (inline with [Bedrock](https://github.com/roots/bedrock/blob/ff5e28ac74f1e9aac1b44f8d197054a34eb85079/composer.json#L33)) - Add PHP 7.3 and 7.4 to test matrix - Update dependencies See: roots#4
|
Need help fixing https://travis-ci.com/github/roots/wp-config/jobs/297776514#L267 |
Merged
It's probably |
roots#7 (comment) Co-Authored-By: Austin Pray <[email protected]>
tangrufus
added a commit
to tangrufus/wp-config
that referenced
this pull request
Mar 13, 2020
roots#7 (comment) Co-Authored-By: Austin Pray <[email protected]>
tangrufus
added a commit
to tangrufus/wp-config
that referenced
this pull request
Mar 13, 2020
austinpray
reviewed
Mar 13, 2020
| @@ -28,12 +28,12 @@ echo WP_DEBUG_DISPLAY; | |||
|
|
|||
| Just run `make` to do everything | |||
|
|
|||
| We use PHPUnit 5 because it has compatibility for PHP 5.6 | |||
| We use PHPUnit 7 because it has compatibility for PHP 7.1 | |||
There was a problem hiding this comment.
Suggested change
| We use PHPUnit 7 because it has compatibility for PHP 7.1 | |
| We use PHPUnit |
There was a problem hiding this comment.
Shouldn't we explain/warn developers about why we not using the latest versions of PHPUnit?
austinpray
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
that fix in 8430f4e LGTM: we will move off travis eventually so it's only temporary 👍
Fixed by running Also running |
|
🎉 🎉 🎉 thank you @tangrufus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #4