Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(get): Allow setting a default value on Config::get() #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

enhance(get): Allow setting a default value on Config::get() #13

wants to merge 4 commits into from

Conversation

Log1x
Copy link
Member

@Log1x Log1x commented Apr 14, 2020

No description provided.

@coveralls
Copy link

coveralls commented Apr 14, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 51

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 47: 0.0%
Covered Lines: 19
Relevant Lines: 19
💛 - Coveralls

austinpray
austinpray requested changes Apr 14, 2020
View reviewed changes
Copy link
Collaborator

@austinpray austinpray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some failing test cases 5244479

@Log1x @austinpray
Update tests/ConfigTest.php
8dac854 
Co-Authored-By: Austin Pray <[email protected]>
@retlehs retlehs requested a review from QWp6t January 26, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinpray austinpray austinpray requested changes

@QWp6t QWp6t Awaiting requested review from QWp6t

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Log1x @coveralls @austinpray