Skip to content

Commit

Permalink
🩹 fix(none): fix #2612 (#2613)
Browse files Browse the repository at this point in the history
- Fix: #2612 
- Strictly define type of `Extension.logger`

## Type of change

**PATCH: backwards compatible change**
  • Loading branch information
kellymears authored Jun 27, 2024
1 parent e528871 commit 9c17ee9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions sources/@roots/bud-framework/src/extension/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import get from '@roots/bud-support/get'
import isFunction from '@roots/bud-support/isFunction'
import isObject from '@roots/bud-support/isObject'
import isUndefined from '@roots/bud-support/isUndefined'
import logger from '@roots/bud-support/logger'
import logger, {type Logger} from '@roots/bud-support/logger'
import set from '@roots/bud-support/set'
import DynamicOption, {
isValue as isDynamicOption,
Expand Down Expand Up @@ -154,7 +154,7 @@ export class Extension<
: this.enabled
}

public get logger(): any {
public get logger(): Logger {
const scopes = []

this.app.isChild && scopes.push(this.app.label)
Expand Down
2 changes: 1 addition & 1 deletion sources/@roots/bud-stylelint/src/extension/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export default class BudStylelintWebpackPlugin extends BudStylelintPublicApi {
if (!configFile?.ext) return

const config = await configFile.module().catch(e => {
this.logger.warning(`error importing ${configFile.path}`, e)
this.logger.warn(`error importing ${configFile.path}`, e)
})

if (!config) return
Expand Down

0 comments on commit 9c17ee9

Please sign in to comment.