Improve support for environment types and fix description of plugin #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New behaviour: 1. Resolve the environment type: 1. Use the value of the `WP_ENV` constant if defined and palpable. 2. Otherwise, use the value of the `wp_get_environment_type()` function if defined (introduced in WordPress 5.0.0). 3. Otherwise, use `NULL`. 2. Filter the environment type with the following hook: * `roots/bedrock/disallow_indexing_environment_type` 3. Display the notice: 1. If the environment type is palpable, display the notice with the filtered environment type. 2. Otherwise, display a shorter notice that does not reference the environment type.
Fixed the description of the plugin to indicate that it relies on the value of a `DISALLOW_INDEXING` constant and not `WP_ENV`. The latter constant only being used as a reference in an dashboard notice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the description of the plugin in the README to indicate that it relies on the value of a
DISALLOW_INDEXINGconstant and notWP_ENV. The latter constant only being used as a reference in an dashboard notice.Also added support for
WP_ENVIRONMENT_TYPEand support for omittingWP_ENV. Proposed behaviour:WP_ENVconstant if defined and palpable.wp_get_environment_type()function if defined (introduced in WordPress 5.0.0).NULL.roots/bedrock/disallow_indexing_environment_type