Feat: Add script to replace keyword placeholders with user input #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: config file name not changing Opt: remove unused variables Fix: author_email not changing in composer.json Fix: composer package name placeholder use correct variable Fix: don't run composer test script because it does not exist
Log1x
requested changes
May 26, 2024
|
I'd like to get rid of all the curl/endpoint stuff as well as any over the top "automation" where possible. The Filament team's take in their plugin skeleton might be a good place to draw some inspiration on simplifying things: https://github.com/filamentphp/plugin-skeleton/blob/main/configure.php |
|
Thanks for the comments @Log1x 🙇♂️. The code styling in composer.json is corrected, and I've simplified the configure.php. Let me know what you think now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a PHP script that automates the process of replacing the dummy Class Names, Namespaces, File names and etc, with real user entered data.