Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tutorials] Create a new 'Visualisation tutorials' group #17071

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[tutorials] Create a new 'Visualisation tutorials' group #17071

wants to merge 1 commit into from

Conversation

martamaja10
Copy link
Contributor

During Hackathon, together with Monica we came up with an idea to organise the groups of tutorials better. We propose to move all the tutorials categories that are related to visualising data in various ways to be moved to a parent directory "Data visualisation tutorials". We plan to form similar parent directories for other categories, for example, Math and io.

The parent directory will have a description with what is included inside (not done now as we first should discuss if such solution is acceptable).

@martamaja10 martamaja10 requested a review from dpiparo November 26, 2024 16:08
@martamaja10 martamaja10 force-pushed the create_datavis_category branch from 375a127 to 231560b Compare November 26, 2024 16:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Test Results

    18 files      18 suites   3d 17h 36m 17s ⏱️
 2 664 tests  2 663 ✅ 0 💤 1 ❌
46 234 runs  46 233 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 0a06e0a.

♻️ This comment has been updated with latest results.

@martamaja10 martamaja10 force-pushed the create_datavis_category branch from 231560b to 570e76a Compare November 27, 2024 13:05
@martamaja10 martamaja10 changed the title [tutorials] Create a new 'Data visualisation tutorials' group [tutorials] Create a new 'Visualisation tutorials' group Nov 27, 2024
@martamaja10 martamaja10 force-pushed the create_datavis_category branch 7 times, most recently from 994cd51 to e04b39b Compare December 3, 2024 16:03
@martamaja10 martamaja10 force-pushed the create_datavis_category branch from e04b39b to e73bf44 Compare December 3, 2024 16:07
@martamaja10 martamaja10 force-pushed the create_datavis_category branch 3 times, most recently from 027bdda to 859c5a6 Compare December 6, 2024 15:04
@martamaja10
Copy link
Contributor Author

the failing tests don't seem related (the CI was run quite a few times as well)

@martamaja10 martamaja10 force-pushed the create_datavis_category branch from 859c5a6 to 63e1f9e Compare December 9, 2024 13:00
agheata
agheata requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@agheata agheata left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martamaja10 the tutorials: assembly.C and geodemo.C demonstrate different geometry features and their main purpose is not visualization so I would keep them in tutorials/geom. No need to re-run the CI after moving them.

@martamaja10 martamaja10 force-pushed the create_datavis_category branch 6 times, most recently from a67c326 to 84f9f72 Compare December 13, 2024 09:35
@martamaja10
Copy link
Contributor Author

@martamaja10 the tutorials: assembly.C and geodemo.C demonstrate different geometry features and their main purpose is not visualization so I would keep them in tutorials/geom. No need to re-run the CI after moving them.

Hi Andrei! I moved those tutorials back in the Geometry category (tutorials/geom), the other geom tutorials stay in tutorials/visualisation/geom. Please let me know if this is good for you.

@agheata
Copy link
Member

agheata commented Dec 13, 2024

@martamaja10 the tutorials: assembly.C and geodemo.C demonstrate different geometry features and their main purpose is not visualization so I would keep them in tutorials/geom. No need to re-run the CI after moving them.

Hi Andrei! I moved those tutorials back in the Geometry category (tutorials/geom), the other geom tutorials stay in tutorials/visualisation/geom. Please let me know if this is good for you.

Perfect, thanks!

@martamaja10
[tutorials] Create a new 'Visualisation Tutorials' group
0a06e0a 
and move topically related tutorials categories inside:
- graphs
- graphics
- TWebCanvas
- GUI and web GUI
- event display tutorials
- geometry
- image
- OpenGL and Cocoa

The changes also involve updating all the necessary
paths (across all of ROOT repository, including the
CODEOWNERS file) and running
git clang on the tutorials of this new group.
Note some of the geometry tutorials are kept separately
in the `tutorials/geom` folders.
@martamaja10 martamaja10 force-pushed the create_datavis_category branch from 84f9f72 to 0a06e0a Compare December 13, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agheata agheata agheata approved these changes

@couet couet couet approved these changes

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@linev linev Awaiting requested review from linev linev is a code owner

@osschar osschar Awaiting requested review from osschar osschar is a code owner

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

Assignees

@mdessole mdessole

@martamaja10 martamaja10

Labels
2nd Hackathon in:Tutorials
Projects
2nd ROOT Hackathon
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martamaja10 @agheata @couet @mdessole