refactor wallet context and fixup account cli #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baichuan3
requested review from
wow-sven,
templexxx and
pause125
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jolestar
reviewed
Oct 4, 2023
| pub server_config: PersistedConfig<ServerConfig>, | ||
| pub keystore: Keystore<K, V>, |
There was a problem hiding this comment.
We have not found a suitable approach to supporting the Ethereum transaction in CLI. We can make the Keystore<K<V> to Keystore<RoochAddress, RoochKeyPair>. After we support other KeyPairType to the WalletContext, we can refactor it later.
There was a problem hiding this comment.
I merge this PR first, we can refactor it later.
jolestar
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #906
Summary