Refactor account balance for support balance API and add some test case #774
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
After refactor, encounter a deadlock in RPC Server. Try to solve RPC server hang caused by futures::executor::block_on when impl MoveFunctionCall for the RPC Server. |
| pub struct AnnotatedCoinView { | ||
| type_: StructTagView, | ||
| struct_type: StructTagView, |
There was a problem hiding this comment.
We need to unify the StructTag field name.
Sometimes, we use struct_tag
rooch/moveos/moveos-types/src/object.rs
Lines 377 to 381 in a635258
Sometimes, we use type_
rooch/crates/rooch-rpc-api/src/jsonrpc_types/move_types.rs
Lines 49 to 55 in a635258
But in the move-language/move repo, AnnotatedMoveStruct use type_.
pub struct AnnotatedMoveStruct {
pub abilities: AbilitySet,
pub type_: StructTag,
pub value: Vec<(Identifier, AnnotatedMoveValue)>,
}
What do you think about this? @wow-sven @stevenlaw123
There was a problem hiding this comment.
Unify to type_ and rename via serde?
#[serde(rename = "type")]
pub type_: StructTagView,There was a problem hiding this comment.
already unify to type_
| // self.rpc_service.execute_view_function(function_call).await | ||
| // })?; | ||
|
|
||
| let function_result = |
There was a problem hiding this comment.
We can not use futures::executor::block_on here, we need to get the tokio Runtime and use the Runtime block_on. https://tokio.rs/tokio/topics/bridging
| } | ||
|
|
||
| lazy_static! { | ||
| static ref RUNTIME: Runtime = tokio::runtime::Builder::new_multi_thread() |
There was a problem hiding this comment.
The tokio runtime needs to pass from the main function to the service. This runtime is another runtime, not in the same runtime which starts the service.
There was a problem hiding this comment.
It will encounter hung up if only one runtime, when use futures::executor::block_on.
I tried use tokio::block_up, but also failed when call_function execute.
There was a problem hiding this comment.
The main function runtime should be built with multi-thread. If this approach works, we can refactor it later.
| @@ -239,6 +239,17 @@ module rooch_framework::coin { | |||
| } | |||
| } | |||
|
|
|||
| /// Return coin info handle | |||
| public fun coin_info_handle(ctx: &StorageContext): Option<ObjectID> { | |||
| if (account_storage::global_exists<CoinInfos>(ctx, @rooch_framework)) | |||
There was a problem hiding this comment.
I think this should be ensured via the Genesis transaction, so it should always exist.
| pub struct AnnotatedCoinView { | ||
| type_: StructTagView, | ||
| struct_type: StructTagView, |
There was a problem hiding this comment.
Unify to type_ and rename via serde?
#[serde(rename = "type")]
pub type_: StructTagView,
resolve TODOs in #760
And refactor account balance for support Rooch balance API.