Set the gas parameter in the native function. #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenlaw123
requested review from
jolestar,
baichuan3,
wow-sven and
pause125
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
stevenlaw123
force-pushed
the
native_function_gas_parameter
branch
2 times, most recently
from
eb7f5e7 to
f332a56
Compare
pause125
reviewed
Sep 3, 2023
| use moveos_stdlib::natives::moveos_stdlib::move_module::GasParameters; | ||
|
|
||
| crate::natives::gas_parameter::native::define_gas_parameters_for_natives!(GasParameters, "move_module", [ | ||
| [.module_name_inner.base, "module_name_inner.base", (5 + 1) * MUL], |
There was a problem hiding this comment.
What do the numbers 5 and 1 represent in (5 + 1) * MUL?
There was a problem hiding this comment.
The calculation method of (5 + 1) * MUL is borrowed from Starcoin, and if needed, it can be changed to something else.
stevenlaw123
force-pushed
the
native_function_gas_parameter
branch
from
f332a56 to
3333682
Compare
jolestar
approved these changes
Sep 4, 2023
stevenlaw123
force-pushed
the
native_function_gas_parameter
branch
2 times, most recently
from
3db7c03 to
5a8a168
Compare
add license info add missed license info remove unused code update the git version of the Move library cargo fmt update Cargo.lock
stevenlaw123
force-pushed
the
native_function_gas_parameter
branch
from
3c5fd75 to
8a12eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an initialize GasParameter for native functions using
rooch_framework::natives::GasParameters::initial();.Later, there is a plan to refactor this approach as the current method hardcodes the GasParameter in the code.
The plan is to use a configuration file to automatically generate GasParameter objects.