docs(data flow): add force inclusion, L1toL2 messaging #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ong period of inactivity.
In multi-chain settlement, we rely on L2 nodes to confirm the state (since the state root of Rooch is not available to the settlement chain alone). Therefore, freezing the sequencer directly will prevent users from withdrawing their assets from L2. For these reasons, we need the sequencer rotation mechanism to be able to serve the malicious nodes even if they are forcibly frozen.
basic roles & contracts layers
Deposits confuse people and can easily be confused with asset transfers. Messaging is much more underlying, while asset transfer (deposits, withdrawals) is just a function realised through messaging. To better reflect this underlying logic, I dropped the use of deposit as the name for L1 to L2 messaging
Deposits confuse people and can easily be confused with asset transfers. Messaging is much more underlying, while asset transfer (deposits, withdrawals) is just a function realised through messaging. To better reflect this underlying logic, I dropped the use of deposit as the name for L1 to L2 messaging
templexxx
changed the title
templexxx
requested review from
wow-sven,
geometryolife and
Mine77
as code owners
jolestar
reviewed
Sep 11, 2023
Comment on lines
+19
to
+20
| 1. `target`: L2 合约地址 | ||
| 2. `msg`: L2 tx 的 calldata |
There was a problem hiding this comment.
这里感觉需要根据 Rooch 以及 Move 做一下调整。比如 Move 中 target 可能不是一个合约地址，而是一个 module::function，或者直接把当前的 MoveAction 打包进去。不过也可以等有初步 demo 实现的时候再调整。
There was a problem hiding this comment.
这里写 address 也犹豫了挺久。因为我们是多链，这个合约在 L1 上。我可以写个括号备注 target 可能的类型
There was a problem hiding this comment.
这篇文档属于技术实现的一部分。之后需要调整一下文档目录结构，把技术实现方案和 highlights 拆分开。
jolestar
reviewed
Sep 11, 2023
| 1. `sequence`: 中继消息序列号 | ||
| 2. `sender`: 消息发送方 | ||
| 3. `target`: L2 合约地址 | ||
| 4. `min_gas_amount`: L2 上允许使用的最小 gas 数量，即对调用 `target` 的估计值。 |
There was a problem hiding this comment.
这里为什么是最小，而不是 min_gas_amount?
There was a problem hiding this comment.
这个值随后会根据 msg 的长度进行估算并加上其他的固定 gas 开销得到 gas_amount
gas_amount = min_gas_amount (target 的调用预估）+ 固定开销 + 消息开销等
Block header information for light nodes needs to meet a certain level of timeliness to break circular arguments
jolestar
approved these changes
Sep 17, 2023
|
I merged this PR first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Force inclusion:
How it works on multi chain
L1 to L2 messaging:
TODO
After it has been approved, I will fix markdown issues and submit the English version in this PR and merge