feat(da): add exec cmd for da chunks execution and verification #3054
+599
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added full hash output for namespace command and refined the exec command with optional executor handling and improved transaction verification logic. Updated documentation with new usage instructions and examples.
Ensure the same `genesis` instance is used for encoding and initialization. This prevents potential inconsistencies and aligns with the expected behavior of the `RoochGenesis` object.
Refactored the `export_path` field to be optional in the `re-genesis` command. Updated related logic to handle `Option<PathBuf>` for better flexibility and error handling.
Reordered transaction handling to ensure proper execution. Moved `handle_tx_output` invocation to follow the sequencer save operation for improved logic flow.
Added a detailed execution and verification process for transactions, including parallel producer-consumer handling. Integrated support for Bitcoin RPC client, extended `ExecCommand` functionality, and updated dependencies with `coerce`.
Add logging to track execution time and average processing time for every 10,000 transactions. This helps monitor performance and improve debugging during transaction processing.
Refactor to separate transaction storage (`MoveOSStore`) from the executor, enabling better modularity and reuse: avoiding executor get execution info blocking execution Improves transaction handling by introducing `ExecMsg`
Enhances error handling in `ExecInner::run` by refining error contexts for producer and consumer results. Removes unnecessary logs and ensures proper cleanup of resources for better reliability.
…ockBody when produce Introduce atomic counters to track progress and log execution stats. This includes tracking completed executions and verified transaction order, with periodic logging to enhance observability. Producer fetch l1 block directly, avoiding blocking fetch in Consumer
Add tracking for produced transactions via an AtomicU64 counter. Update README with steps to download segments using `getda` and clarify unpacking instructions.
Updated the logging condition to log every 10,000th transaction. This improves visibility and avoids unnecessary output for smaller transaction counts. fix attempt to subtract with overflow by add 1 after fetch_add
Added detailed instructions and example command for executing a transaction list in Rooch DA, including expected output log for successful execution. This enhances clarity for users handling transaction execution.
popcnt1
requested review from
wow-sven,
baichuan3,
jolestar and
pause125
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Corrected the average transaction cost calculation to use floating-point precision, ensuring more accurate and readable logging output. This enhances the clarity of performance metrics for transaction execution.
jolestar
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary