[Break RPC]optimize memory usage of query_object_states #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pause125
requested review from
popcnt1,
wow-sven,
baichuan3,
jolestar and
steelgeek091
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
pause125
force-pushed
the
optimize-memory
branch
from
962abc9 to
a2cd389
Compare
steelgeek091
approved these changes
Nov 12, 2024
pause125
force-pushed
the
optimize-memory
branch
from
79671cd to
a838c6c
Compare
pause125
force-pushed
the
optimize-memory
branch
from
a838c6c to
4335e12
Compare
pause125
force-pushed
the
optimize-memory
branch
from
4335e12 to
54cd482
Compare
wow-sven
approved these changes
Nov 14, 2024
pause125
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimize memory usage of query_object_states
Main changes:
Define
AnnotatedMoveStructVectorViewto store vector of Move structs. This makes memory usage decreased from 9.26 GB to 768 MB.This PR will break RPC response. Please pay attention @wow-sven