-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(DA): refine DA stream define and implementation #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced DA server with chunk and segment handling functionality including compression with lz4. Improved batch submission process, addressing batch data integrity and submission logic.
Introduce batch retrieval and chunk creation from segments. This adds new methods to handle batch data and validate segment consistency, enhancing the chunk and segment interfaces.
Add detailed log messages for segment submission to Celestia and Open-DA nodes. Improves error handling and debug capability by logging segment IDs, namespaces, commitments, and errors.
Refactor deployment workflows for distinct environments. Added separate scripts for testnet and mainnet deployments. Introduced a new constant for default max retry times in DAServerOpenDAActor.
popcnt1
requested review from
jolestar,
baichuan3,
yourmoonlight,
wow-sven and
steelgeek091
as code owners
September 19, 2024 12:25
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@popcnt1 is attempting to deploy a commit to the Rooch Team on Vercel. A member of the Team first needs to authorize it. |
jolestar
reviewed
Sep 19, 2024
jolestar
approved these changes
Sep 19, 2024
yourmoonlight
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
baichuan3
reviewed
Sep 19, 2024
Updated deploy_rooch_mainnet.sh to exclude the faucet container when stopping and removing Docker containers. This ensures the faucet container stays running during the deployment process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary