Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Migrate Bitseed cli to rooch #2635

Merged
merged 12 commits into from
Sep 21, 2024
Merged

[cli] Migrate Bitseed cli to rooch #2635

merged 12 commits into from
Sep 21, 2024

Conversation

jolestar
Copy link
Contributor

@jolestar jolestar commented Sep 14, 2024 •
edited
Loading

Summary

  1. Rename BitcoinOutPointView to OutPointView
  2. Remove BlockHash from Seed
  3. Use local keystore to sign the tx.
  4. Refactor UTXO selector.
  5. Use rooch bitseed to replace the bitseed image in integration test.

@vercel Vercel
Copy link

vercel bot commented Sep 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 2:29am
rooch-portal-v2.1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 2:29am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 2:29am

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 14, 2024 •
edited
Loading

Dependency Review

The following issues were found:

  • ❌ 2 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
  • ⚠️ 16 packages with OpenSSF Scorecard issues.

View full job summary

@jolestar jolestar mentioned this pull request Sep 19, 2024
Merged
@jolestar
Copy link
Contributor Author

@yubing744 @steelgeek091 help review

@jolestar jolestar merged commit e5a9566 into main Sep 21, 2024
10 of 11 checks passed
@jolestar jolestar deleted the bitseed_cli branch September 21, 2024 14:46
@yubing744
Copy link
Collaborator

@jolestar
bitseed_run_cmd in crates/testsuite/tests/integration.rs can be removed.
The module crates/testsuite/tests/images/bitseed.rs can also be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelgeek091 steelgeek091 steelgeek091 approved these changes

@wow-sven wow-sven Awaiting requested review from wow-sven wow-sven is a code owner

@yubing744 yubing744 Awaiting requested review from yubing744 yubing744 is a code owner

@baichuan3 baichuan3 Awaiting requested review from baichuan3 baichuan3 is a code owner

@pause125 pause125 Awaiting requested review from pause125 pause125 is a code owner

@yourmoonlight yourmoonlight Awaiting requested review from yourmoonlight yourmoonlight is a code owner

@popcnt1 popcnt1 Awaiting requested review from popcnt1 popcnt1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitseed] Migrate the bitseed command to rooch cli?
3 participants
@jolestar @yubing744 @steelgeek091