-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[State] Support state sync and provide RPC to sync state #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
baichuan3
force-pushed
the
sync_state
branch
from
September 12, 2024 13:22
60070d9
to
91b88bc
Compare
…ss, for reduce sender store size in indexer by using short_str_lossless
baichuan3
force-pushed
the
sync_state
branch
from
September 12, 2024 13:31
91b88bc
to
c4e7aa2
Compare
baichuan3
requested review from
jolestar,
popcnt1,
wow-sven and
pause125
as code owners
September 12, 2024 13:33
jolestar
reviewed
Sep 12, 2024
jolestar
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
RocksDB uses compaction to remove expired keys, setting TTL directly in RocksDB may not be a good choice.
and it may also have a performance impact.
Cleaning up state change set data regularly may be an option