-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Implement rooch bitcoin command to suppor taproot multisign and bump bitcoin to 0.32.2 #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest FilesCargo.lock
|
jolestar
force-pushed
the
cli_bitcoin
branch
from
September 10, 2024 10:23
5f97ee5
to
0b8c541
Compare
jolestar
force-pushed
the
cli_bitcoin
branch
from
September 10, 2024 20:44
0b8c541
to
369f536
Compare
jolestar
requested review from
pause125,
baichuan3,
wow-sven,
popcnt1,
yourmoonlight and
steelgeek091
as code owners
September 10, 2024 21:59
baichuan3
approved these changes
Sep 11, 2024
jolestar
changed the title
[CLI] Implement rooch bitcoin command and bump bitcoin to 0.32.2
[CLI] Implement rooch bitcoin command to suppor taproot multisign and bump bitcoin to 0.32.2
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rooch bitcoin
commandclose #2414 and close #2581
Usage:
Got the multisign_bitcoin_address
rooch bitcoin sign-tx -s $Pubkey1_address /tmp/xxxxx.psbt
rooch bitcoin sign-tx -s $Pubkey2_address /tmp/xxxxx.psbt
Got xxxxx.tx
Note: the taproot multisign signature order in the witness should be reversed with the public key order in the script. Thanks to rust-bitcoin/rust-bitcoin#2241