fix(common): add Linux-specific file caching logic #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented conditional logic in the FileCacheManager module where certain methods are only applicable when the target OS is Linux. Methods like `new()` and `drop_cache_range()` are now specifically designated for Linux, while others are designated otherwise. This ensures correct functioning across diverse OS.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
This commit changes the way POSIX functions are called in the file_cache module. Instead of importing the functions directly from libc, they are now referred to via the libc namespace. This improves code clarity by making it clear where these functions originate from.
The commit updates file import in file_cache.rs by replacing individual usages with direct namespace access. These changes include the way the File and Error classes from the std library are accessed. The aim is to improve readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented conditional logic in the FileCacheManager module where certain methods are only applicable when the target OS is Linux. Methods like
new()anddrop_cache_range()are now specifically designated for Linux, while others are designated otherwise. This ensures correct functioning across diverse OS.