Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[genesis] Fix module store size bug #1703

Merged
merged 1 commit into from
May 18, 2024
Merged

[genesis] Fix module store size bug #1703

merged 1 commit into from
May 18, 2024

Conversation

jolestar
Copy link
Contributor

Summary

  1. Fix [object] ModuleStore object field size is incorrect after init genesis #1565 to support framework upgrade.
  2. Auto-create account when transfer; after [Framework] Deprecated the CoinStores in the account resource. #1669, we can remove the auto-create logic.

@vercel Vercel
Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-rooch-portal-v1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 7:00am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) May 18, 2024 7:00am

@jolestar
Copy link
Contributor Author

I merge this PR first. @pause125 @baichuan3

@jolestar jolestar merged commit 094e21c into main May 18, 2024
7 of 9 checks passed
@jolestar jolestar deleted the fix_module_store_size branch May 18, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baichuan3 baichuan3 Awaiting requested review from baichuan3 baichuan3 is a code owner

@wow-sven wow-sven Awaiting requested review from wow-sven wow-sven is a code owner

@pause125 pause125 Awaiting requested review from pause125 pause125 is a code owner

@steelgeek091 steelgeek091 Awaiting requested review from steelgeek091 steelgeek091 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[object] ModuleStore object field size is incorrect after init genesis
1 participant
@jolestar