Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Check the module is exist before execute the view function #1700

Merged
merged 3 commits into from
May 20, 2024
Merged

[bug] Check the module is exist before execute the view function #1700

merged 3 commits into from
May 20, 2024

Conversation

vegetabledogdog
Copy link
Contributor 

rooch move view --function 0x3::noexist_module::noexist_function
Module does not exist error: noexist_module

#1004

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-rooch-portal-v1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 3:56am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 3:56am

jolestar
jolestar reviewed May 17, 2024
View reviewed changes
crates/rooch/src/commands/move_cli/commands/run_view_function.rs Outdated
@@ -50,6 +50,23 @@ impl CommandAction<AnnotatedFunctionResultView> for RunViewFunction {
async fn execute(self) -> RoochResult<AnnotatedFunctionResultView> {
let context = self.context.build()?;
let address_mapping = context.address_mapping();
let module_id = self
.function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check it on the RPC server side, not the client side.

@vegetabledogdog
Copy link
Contributor Author 

rooch move view --function 0x3::noexist_module::noexist_function
View function error: RPC call failed: ErrorObject { code: ServerError(-32000), message: "Module does not exist: 0000000000000000000000000000000000000000000000000000000000000003::noexist_module", data: None }

@jolestar jolestar linked an issue May 18, 2024 that may be closed by this pull request
[bug] Check the module is exist before execute the view function #1004
Closed
@jolestar
Copy link
Contributor

Please help to fix the clippy error

error: using clone on type AccountAddress which implements the Copy trait
--> crates/rooch-rpc-server/src/service/rpc_service.rs:84:17
|
84 | module_id.address().clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: *module_id.address()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: -D clippy::clone-on-copy implied by -D warnings
= help: to override -D warnings add #[allow(clippy::clone_on_copy)]

@jolestar jolestar merged commit bcb3056 into rooch-network:main May 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolestar jolestar jolestar approved these changes

@baichuan3 baichuan3 Awaiting requested review from baichuan3 baichuan3 is a code owner

@wow-sven wow-sven Awaiting requested review from wow-sven wow-sven is a code owner

@pause125 pause125 Awaiting requested review from pause125

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Check the module is exist before execute the view function
2 participants
@vegetabledogdog @jolestar