Simplify `golden-ratio-mode' #48
Conversation
* golden-ratio.el (golden-ratio-in-progress): New defvar. (golden-ratio): Use `golden-ratio-in-progress' instead of turning off the mode. (select-window): New defadvice; remove all other stuff. (golden-ratio-mode): Remove all hooks, the only entry point is `select-window'. This change will greatly simplify the life of package writers that have to work around `golden-ratio-mode'. Re abo-abo/hydra#64.
* golden-ratio.el (golden-ratio--resize-window): Update. Shrinking selected window may result in enlarging a window that was supposed to be ignored.
* golden-ratio.el (split-window): New advice. (golden-ratio): Fixup.
|
Thanks, but now golden-ratio is not happening when splitting windows. |
No problem, just needs one more advice.
Fixed up, that logic was lost in the merge conflict. |
Simplify `golden-ratio-mode'
|
Ok looks good now, thanks. |
|
Oleh Krehel [email protected] writes:
Now scrolling in Gnus is broken... Thierry |
It works fine for me. |
|
Oleh Krehel [email protected] writes:
I mean gnus-summary-scroll-up (press RET repetitively from summary Maybe it is working in emacs-25 due to a difference in select-window, Disabling golden-ratio-mode let it working, switching to version 1.0 of Please try to fix, otherwise I will look into this ASAP (not the time Thanks. Thierry |
Its scrolls fine in 24.5.2. Although it's weird to have golden-ratio on at all for gnus, since it makes the summary (which I like to keep small) much larger than the article. |
No it doesn't. I have opened an issue #49 . |
* golden-ratio.el: Fix issue by reverting PR (#48).
No description provided.