fix findBestRun

roman-vorobiov · Jan 10, 2025 · fc1a031 · fc1a031
1 parent d97036c
commit fc1a031
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/evolve_analytics.meta.js b/evolve_analytics.meta.js
@@ -1,7 +1,7 @@
 // ==UserScript==
 // @name         Evolve Analytics
 // @namespace    http://tampermonkey.net/
-// @version      0.10.6
+// @version      0.10.7
 // @description  Track and see detailed information about your runs
 // @author       Sneed
 // @match        https://pmotschmann.github.io/Evolve/

diff --git a/src/exports/historyFiltering.ts b/src/exports/historyFiltering.ts
@@ -50,10 +50,14 @@ export function applyFilters(history: HistoryManager, view: ViewConfig): History
     return runs.reverse();
 }
 
-function findBestRunImpl(runs: HistoryEntry[]): HistoryEntry | undefined {
+function findBestRunImpl(history: HistoryManager, view: ViewConfig): HistoryEntry | undefined {
     let best: HistoryEntry | undefined = undefined;
 
-    for (const run of runs) {
+    for (const run of history.runs) {
+        if (!shouldIncludeRun(run, view, history)) {
+            continue;
+        }
+
         if (best === undefined || runTime(run) < runTime(best)) {
             best = run;
         }
@@ -64,14 +68,14 @@ function findBestRunImpl(runs: HistoryEntry[]): HistoryEntry | undefined {
 
 const bestRunCache: Record<string, HistoryEntry> = {};
 
-export function findBestRun(runs: HistoryEntry[], view: ViewConfig): HistoryEntry | undefined {
+export function findBestRun(history: HistoryManager, view: ViewConfig): HistoryEntry | undefined {
     const cacheKey = `${view.resetType}.${view.universe ?? "*"}`;
     const cacheEntry = bestRunCache[cacheKey];
     if (cacheEntry !== undefined) {
         return cacheEntry;
     }
 
-    const best = findBestRunImpl(runs);
+    const best = findBestRunImpl(history, view);
     if (best !== undefined) {
         bestRunCache[cacheKey] = best;
     }

diff --git a/src/ui/graph.ts b/src/ui/graph.ts
@@ -267,7 +267,7 @@ function* rectPointerMarks(plotPoints: PlotPoint[], history: HistoryEntry[], seg
 
 export function makeGraph(history: HistoryManager, view: View, currentRun: LatestRun, onSelect: (run: HistoryEntry | null) => void) {
     const filteredRuns = applyFilters(history, view);
-    const bestRun = findBestRun(filteredRuns, view);
+    const bestRun = findBestRun(history, view);
 
     const milestones: string[] = Object.keys(view.milestones);