HT8 #38
Open
HT8 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romabelka
reviewed
Jul 17, 2017
| if (!article) return null | ||
| return ( | ||
| <div ref = {this.setContainerRef}> | ||
| <h3>{article.title}</h3> | ||
| <button onClick = {toggleOpen}> | ||
| {isOpen ? 'close' : 'open'} | ||
| {isOpen ? | ||
| this.context.dictionary.close[this.context.language] |
There was a problem hiding this comment.
Лучше сделай отдельный декоратор или компонент для локализации
|
|
||
| static childContextTypes = { | ||
| user: PropTypes.string | ||
| user: PropTypes.string, | ||
| dictionary: PropTypes.object, |
There was a problem hiding this comment.
проще хранить только нужный словарь
| @@ -40,8 +40,15 @@ export default (articleState = defaultState, action) => { | |||
| return articleState.set('loading', true) | |||
|
|
|||
| case LOAD_ALL_ARTICLES + SUCCESS: | |||
| const articles = arrToMap(response, ArticleRecord).map((article) => { | |||
There was a problem hiding this comment.
тут ты перемудрил, можно просто мерджить в другом порядке
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Баг исправил, изменив логику кейса LOAD_ALL_ARTICLES + SUCCESS в редьюсере.
Изменение языка сделал, но в некоторых компонентах, например, в CommentForm, почему-то не работает динамическое именение языка. Что я упустил?