Merge branch 'master' of https://github.com/rollup/rollup into sync-a…

…6448b99

CHANGELOG.md

@@ -1,4 +1,16 @@
-# rollup changelog
+    # rollup changelog
+
+## 3.29.4
+
+_2023-09-28_
+
+### Bug Fixes
+
+- Fix static analysis when an exported function uses callbacks (#5158)
+
+### Pull Requests
+
+- [#5158](https://github.com/rollup/rollup/pull/5158): Deoptimize all parameters when losing track of a function (@lukastaegert)
 
 ## 3.29.3
 

browser/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rollup/browser",
-  "version": "3.29.3",
+  "version": "3.29.4",
   "description": "Next-generation ES module bundler browser build",
   "main": "dist/rollup.browser.js",
   "module": "dist/es/rollup.browser.js",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "rollup",
-  "version": "3.29.3",
+  "version": "3.29.4",
   "description": "Next-generation ES module bundler",
   "main": "dist/rollup.js",
   "module": "dist/es/rollup.js",

src/ast/nodes/shared/FunctionBase.ts

@@ -74,8 +74,13 @@ export default abstract class FunctionBase extends NodeBase {
 		this.getObjectEntity().deoptimizePath(path);
 		if (path.length === 1 && path[0] === UnknownKey) {
 			// A reassignment of UNKNOWN_PATH is considered equivalent to having lost track
-			// which means the return expression needs to be reassigned
+			// which means the return expression and parameters need to be reassigned
 			this.scope.getReturnExpression().deoptimizePath(UNKNOWN_PATH);
+			for (const parameterList of this.scope.parameters) {
+				for (const parameter of parameterList) {
+					parameter.deoptimizePath(UNKNOWN_PATH);
+				}
+			}
 		}
 	}
 

test/function/samples/mutate-via-parameter/_config.js

@@ -0,0 +1,9 @@
+const assert = require('node:assert');
+
+module.exports = defineTest({
+	description:
+		'respects variable mutations via unknown parameter values if we lose track of a function',
+	exports({ test }) {
+		assert.ok(test(state => (state.modified = true)));
+	}
+});

test/function/samples/mutate-via-parameter/main.js

@@ -0,0 +1,8 @@
+export function test(callback) {
+	const state = {
+		modified: false
+	};
+	callback(state);
+	if (state.modified) return true;
+	return false;
+}