Add clippy to pipeline and fix remaining issues (#5183)

* Fix all clippy lints

* Add clippy to pipeline

* Fix toolchain for REPL

package.json

@@ -58,8 +58,8 @@
     "lint:js:nofix": "eslint . --cache",
     "lint:markdown": "prettier --write \"**/*.md\"",
     "lint:markdown:nofix": "prettier --check \"**/*.md\"",
-    "lint:rust": "cd rust && cargo fmt",
-    "lint:rust:nofix": "cd rust && cargo fmt --check",
+    "lint:rust": "cd rust && cargo fmt && cargo clippy --fix --allow-dirty",
+    "lint:rust:nofix": "cd rust && cargo fmt --check && cargo clippy",
     "perf": "npm run build:cjs && node --expose-gc scripts/perf.js",
     "perf:init": "node scripts/perf-init.js",
     "prepare": "husky install && node scripts/check-release.js || npm run build:prepare",

rust/bindings_napi/src/lib.rs

@@ -1,5 +1,3 @@
-#![deny(clippy::all)]
-
 use napi::bindgen_prelude::*;
 use napi_derive::napi;
 use parse_ast::parse_ast;

rust/parse_ast/src/convert_ast/annotations.rs

@@ -8,9 +8,6 @@ pub struct SequentialComments {
   annotations: RefCell<Vec<AnnotationWithType>>,
 }
 
-const ASCII_AT: u8 = '@' as u8;
-const ASCII_HASH: u8 = '#' as u8;
-
 impl SequentialComments {
   pub fn add_comment(&self, comment: Comment) {
     if comment.text.starts_with('#') && comment.text.contains("sourceMappingURL=") {
@@ -31,7 +28,7 @@ impl SequentialComments {
       search_position += match_position;
       // Using a byte reference avoids UTF8 character boundary checks
       match &comment.text.as_bytes()[search_position - 1] {
-        &ASCII_AT | &ASCII_HASH => {
+        b'@' | b'#' => {
           let annotation_slice = &comment.text[search_position..];
           if annotation_slice.starts_with("__PURE__") {
             self.annotations.borrow_mut().push(AnnotationWithType {