Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(commonjs): output.exports recommendation also applies to IIFE #1810

Merged

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Nov 5, 2024

Rollup Plugin Name: commonjs

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This recommendation also applies to IIFE format. When setting output.exports: 'named', only the default value is exposed on the exported value.

refs #1639
refs vitejs/vite#18574

@shellscape shellscape merged commit 3efaf75 into rollup:master Dec 15, 2024
10 checks passed
@sapphi-red sapphi-red deleted the docs/commonjs-output-exports-for-iife-too branch December 16, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants