Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replace): add missing sourceMap documentation #1698

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

EduardoAC
Copy link
Contributor

Rollup Plugin Name: @rollup/plugin-replace

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #1697

Description

Documentation missing for sourceMap inclusion, fixed by adding the option as documented in #1697

@EduardoAC EduardoAC requested a review from shellscape as a code owner March 19, 2024 15:11
@EduardoAC EduardoAC force-pushed the fix/sourceMap-document-option branch from c7b2c21 to 3a4fbc5 Compare March 19, 2024 15:15
Copy link
Collaborator

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR. small README change needed to get this merged

@@ -179,6 +179,19 @@ replace({
});
```

### `sourceMap` or `sourcemap`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please place this in alphabetical order (before values)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shellscape Thanks for the feedback, order fixed

@shellscape shellscape merged commit de709c2 into rollup:master Jun 5, 2024
1 of 5 checks passed
younggglcy pushed a commit to younggglcy/plugins that referenced this pull request Jun 6, 2024
* fix(replace): add missing sourceMap documentation

* fix(replace): Update attributes alphabetically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@rollup/plugin-replace] Missing sourceMap option within Readme
2 participants