-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(commonjs)!: bump glob's version #1695
Conversation
Hi any update on this? There is a vulnerability introduced thought this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this update is breaking tests that rely on glob, so we need to figure out what the breaking changes were.
Hello, any updates on this? or is there a workaround
|
CI tests failed due to wrong order returned by |
@younggglcy I think this is good to merge, but please rebase/merge from master again. CI isn't happy. |
BREAKING CHANGES: Requires Node.js version >=16.0.0 or >= 14.17
fixed. |
* chore: bump glob's version BREAKING CHANGES: Requires Node.js version >=16.0.0 or >= 14.17 * fix: let glob match alphabetical order
Rollup Plugin Name:
@rollup/plugin-commonjs
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: resolves #1691
Description
BREAKING CHANGES: Requires Node.js version >=16.0.0 or >= 14.17, this is the same as glob's need.
both
glob
andshx
haveinflight
in their deps, so this PR bumpsglob
to the latest and removesshx
, since it's not been used.