Resolve issue #1652 - Typescript plugin fails to compile the entry point when there is at least one invalid TypeScript file somewhere is the working directory #1653
+76
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmorand
force-pushed
the
issue-1652
branch
3 times, most recently
from
8a6fc73 to
42370bc
Compare
ericmorand
force-pushed
the
issue-1652
branch
from
42370bc to
78d1327
Compare
shellscape
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
I think the changes here look good. Thanks for putting this together. I do think this needs another person to put eyes on it before merging. @NotWoods please take a look if you have the chance.
shellscape
requested review from
guybedford,
tjenkinson,
TrySound and
lukastaegert
|
Apologies for the delay. We always have a shortage of maintainers for this repo, and it doesn't look like anyone else has stepped in to review this. Best I can do is give them another ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
typescriptThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This PR solves the issue described in #1652. It focuses on not creating a breaking changes by ensuring that no existing test was modified - except one that I'd like to discuss with the maintainers.
Basically, what this PR does is to remove the initial emit of all the files included in th working directory and instead emit files that are part of the dependency graph of the entry point.