fix(dynamic-import-vars): Allow a "no files found" error to be emitted as warning #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
changed the title
|
Hey @shellscape! Could you take a look at this when you have time? Thanks :) |
shellscape
requested changes
Nov 25, 2023
shellscape
changed the title
|
Sorry about the latency on reviewing. A little bananas on my end lately. |
Co-authored-by: Andrew Powell <[email protected]>
All good! I never know the etiquette as some people are busy and others just forgot or missed the notification 😄 |
shellscape
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
dynamic-import-varsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: #1611
Description
This PR allows the "no files found" error introduced in #1611 to be emitted as a warning using the existing
warnOnErroroption.