Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add criteria status color; increase message length #2382

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

I-vasilich-I
Copy link
Contributor

@I-vasilich-I I-vasilich-I commented Dec 4, 2023

🟒 Add deploy label if you want to deploy this Pull Request to staging environment

πŸ§‘β€βš–οΈ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

πŸ’‘ Background and solution

image

Screenshot from 2023-12-04 14-39-40

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

Copy link

github-actions bot commented Dec 4, 2023

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

πŸŽ‰ Global Bundle Size Decreased

Page Size (compressed)
global 110.96 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (500 KB)
/admin/courses 388.11 KB 499.07 KB 99.81% (🟒 -0.02%)
/admin/discord-server 360.21 KB 471.17 KB 94.23% (🟑 +0.01%)
/admin/events 360.8 KB 471.76 KB 94.35% (🟑 +0.01%)
/admin/mentor-registry 384.32 KB 495.28 KB 99.06% (🟑 +0.04%)
/admin/notifications 399.25 KB 510.21 KB 102.04% (+/- <0.01%)
/admin/registrations 332.56 KB 443.51 KB 88.70% (🟑 +0.06%)
/admin/tasks 445.32 KB 556.28 KB 111.26% (🟑 +0.70%)
/admin/user-group 384.25 KB 495.21 KB 99.04% (+/- <0.01%)
/applicants 315.6 KB 426.56 KB 85.31% (🟑 +0.01%)
/course/admin/cross-check-table 472.65 KB 583.61 KB 116.72% (πŸ”΄ +7.07%)
/course/admin/events 442.3 KB 553.26 KB 110.65% (🟑 +0.02%)
/course/admin/interviews 383.04 KB 494 KB 98.80% (+/- <0.01%)
/course/admin/mentors 389.38 KB 500.34 KB 100.07% (🟑 +0.34%)
/course/admin/stage-interviews 384.63 KB 495.58 KB 99.12% (+/- <0.01%)
/course/admin/students 397.33 KB 508.28 KB 101.66% (🟑 +0.34%)
/course/admin/tasks 416.21 KB 527.17 KB 105.43% (🟑 +0.10%)
/course/admin/users 383.07 KB 494.02 KB 98.80% (+/- <0.01%)
/course/interview/[type]/feedback 347.98 KB 458.94 KB 91.79% (🟑 +0.16%)
/course/mentor/dashboard 404.29 KB 515.25 KB 103.05% (🟑 +0.11%)
/course/mentor/interview-wait-list 341.28 KB 452.24 KB 90.45% (🟒 -0.01%)
/course/schedule 486.29 KB 597.25 KB 119.45% (🟑 +0.40%)
/course/score 341.84 KB 452.8 KB 90.56% (🟑 +0.01%)
/course/student/auto-test 393.77 KB 504.73 KB 100.95% (🟒 -0.14%)
/course/student/auto-test/task 393.68 KB 504.64 KB 100.93% (🟒 -0.14%)
/course/student/cross-check-review 488.2 KB 599.15 KB 119.83% (πŸ”΄ +13.96%)
/course/student/cross-check-submit 504.43 KB 615.39 KB 123.08% (πŸ”΄ +13.96%)
/course/student/dashboard 400.92 KB 511.88 KB 102.38% (🟒 -0.12%)
/course/submit-scores 417.15 KB 528.11 KB 105.62% (🟑 +0.06%)
/course/team-distributions 385.26 KB 496.22 KB 99.24% (🟒 -0.03%)
/cv/[uuid] 247.65 KB 358.61 KB 71.72% (🟑 +0.06%)
/cv/edit 351.61 KB 462.57 KB 92.51% (🟒 -0.02%)
/heroes 401.29 KB 512.25 KB 102.45% (🟒 -0.02%)
/profile 411.14 KB 522.1 KB 104.42% (🟒 -0.20%)
/profile/notifications 333.72 KB 444.68 KB 88.94% (+/- <0.01%)
/registry/mentor 346.98 KB 457.93 KB 91.59% (🟑 +0.16%)
/registry/student 346.97 KB 457.92 KB 91.58% (🟑 +0.17%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@I-vasilich-I I-vasilich-I merged commit fe29032 into master Dec 20, 2023
6 checks passed
@I-vasilich-I I-vasilich-I deleted the feat/cross-check-criteria-status-color branch December 20, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants