Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(submit-score): remove multiple file upload attribute, add accept attribute #2320

Conversation

ThorsAngerVaNeT
Copy link
Contributor

@ThorsAngerVaNeT ThorsAngerVaNeT commented Oct 17, 2023

🟒 Add deploy label if you want to deploy this Pull Request to staging environment

πŸ§‘β€βš–οΈ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

πŸ”— Related issue link

Describe the source of requirement, like related issue link.

πŸ’‘ Background and solution

Remove Multiple attribute, add access attribute. add type for param in onChange handler.

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

@ThorsAngerVaNeT ThorsAngerVaNeT marked this pull request as draft October 18, 2023 13:18
@ThorsAngerVaNeT ThorsAngerVaNeT changed the title fix(submit-score): multiple file upload fix(submit-score): remove multiple file upload attribute, add accept attribute Oct 24, 2023
@ThorsAngerVaNeT ThorsAngerVaNeT marked this pull request as ready for review October 24, 2023 18:21
@ThorsAngerVaNeT ThorsAngerVaNeT merged commit 39080a1 into rolling-scopes:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants