Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate copy course to new api #2316

Merged
merged 9 commits into from
Nov 1, 2023

Conversation

Alphajax
Copy link
Contributor

@Alphajax Alphajax commented Oct 8, 2023

🟒 Add deploy label if you want to deploy this Pull Request to staging environment

πŸ§‘β€βš–οΈ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

πŸ”— Related issue link(#2147)

Describe the source of requirement, like related issue link.

πŸ’‘ Background and solution

Describe the big picture of your changes here
migrated copy course feature to new api
changed copyCourse request data to use v2 api
created copycourse controller at nest repository
reused copyFromTo(https://github.com/rolling-scopes/rsschool-app/blob/master/nestjs/src/courses/course-schedule/course-schedule.service.ts#L240) function

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

@valerydluski
Copy link
Contributor

Could you also remove the old code?

@valerydluski valerydluski merged commit ebd6dd1 into rolling-scopes:master Nov 1, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants