-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add runtime TIMES
#333
add runtime TIMES
#333
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 12 12
Lines 1003 1011 +8
Branches 22 22
=======================================
+ Hits 995 1003 +8
Misses 8 8 ☔ View full report in Codecov by Sentry. |
These detected memory leaks seem to be caused by the exception thrown from the So, that is rather unrelated to that PR here, but we should definitely address that in another PR. |
From a very brief glance, this looks interesting. I'm away on a conference right now, but I'll have a closer look when I get back home again. |
This is looking really neat. Thank you. Is there something you want to discuss, given that it's still marked [WIP]? Otherwise, I think it's just a matter of adding docs and negative test(s) under 'compilation_errors' before I can merge it. Naming can always be discussed, but I think DYN_TIMES is as good as anything I can come up with. |
Ping! I know I haven't been very attentive lately, but I hope to be able to tag a release in the tear future, say during the weekend July 13-14th. If there are things you want from me to be able to merge this, then let me know. As mentioned before, I'm cool with the change and the names, but would appreciate docs and some more tests. |
Hey, sry for the delay. I'm currently very busy with my thesis, so I won't have much spare time for this during the next month or so. I'm not sure, which tests I should add, as I mostly reuse existing components and already added a couple of tests. The negative tests are in the section beginning at 4835. I would really like to rename it to |
Ok, no worries. There's no hurry. |
Hey, I finally got the time to invest some time into this feature. |
So, I think I'm done. Added the necessary documentation and checked, that all anchors are working as expected. Don't know why codecov now started complaining. |
Never mind codecov. It's being silly. I'll have a look. Thanks! |
This is awesome. Thank you! |
as discussed in this issue #283 it would be very helpful to have the TIMES action configurable with runtime arguments.
This PR aims to add that, without making too much changes to existing symbols (in fact, no changes are made at all).
As this is mainly a sketchup for the actual feature, I'm open for feedback regarding behavior and naming (maybe ``RT_TIMES is a more appropriate name).