Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pre_backup_cmd to backup items (wip) #112

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

felixandersen
Copy link
Contributor

Opening this PR as I did this change locally and thought it would add value to the role.

I have a changing number of databases I need to backup that need to be dumped to file before each backup. Since the names and numbers are not known at playbook-runtime I cannot use the stdin-feature in this role. My solution is a pre_backup_cmd.

Let me know if this is interesting. I am open to refining the change as needed.

@DO1JLR
Copy link
Member

DO1JLR commented Jan 3, 2024

Hi @felixandersen

If I understood it correctly it sounds like a good idea.
But by browsing over the code I am not absoludly sure if I understood it correctly.

Could you give an config example and maybe some minor explaination for the README? 😘

@felixandersen
Copy link
Contributor Author

I added an example to the README to clarify. That specific pre_backup_cmd however is untested. My deployment runs a separate python-script that does a similar thing.

@DO1JLR DO1JLR enabled auto-merge January 26, 2024 14:44
@DO1JLR DO1JLR merged commit 662e96f into roles-ansible:main Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants