Additional utf8mb4 fixes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parent commit attempts to fix a problem with the ENGINE type for table __update_sites_extension. The code being removed here was contributing to that problem. Related history: Joomla Tracker item 23817 (commit 5db5dd) removed all ENGINE type specifications from all table definitions. The intent was to use whatever the default engine was. Unfortunately, it seems they overlooked the __update_sites_extension table in their edits. Tracker item 26929 (commit 4a2128) added the code that is now being deleted here. There's no mention for why the code was added (it's unrelated to the tracker issue), but the code is obviously attempting to convert the previously overlooked __update_sites_extension table so that it, too, uses the default engine, as was the case for all other tables. Tracker item 28854 (commit 0fc0e9) added the ENGINE=InnoDB specification back to all tables, including the __update_sites_extension table. Tracker item 29084 (commit da6182) updates all existing tables (including the __update_sites_extension table) with ENGINE=InnoDB. It seems clear that they were unaware of the code that is now being deleted here, and if they had known of it, they would have deleted it then because it conflicted with what they were doing in their commit.
Errors occur when performing a clean install in instances where the client end of the database connection supports utf8mb4, but the server end does not. Better detection of utf8mb4 support is added to the pdomysql driver.
It should be safe to apply them multiple times. If an error occurs, then there's something that is broken and needs fixing. Don't hide the problem. Also, don't attempt to process empty lines or comments. Doing so could lead to errors. This treatment is consistent with JInstaller::parseSQLFiles().
As previously defined, the method could return true even when $client_version < 5.5.3 (for non-mysqlnd clients).
roland-d
pushed a commit
that referenced
this pull request
Jan 13, 2017
- Improved readability of assertions by using more appropriate assertions - Made some assertions more strict
roland-d
pushed a commit
that referenced
this pull request
Jun 13, 2017
… (joomla#12294) * Cleanups, fixes and a bit of optimizations for site/components batch #5 - com_tags - com_users - com_wrapper Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole * Some more fixes after conflict resolution * - Changed some things according to reviewer's suggestions - Some more changes in updated stuff
roland-d
pushed a commit
that referenced
this pull request
Sep 26, 2018
* This is a combination of 8 commits. This is the 1st commit message: > First WIP version of supporting nested subforms. This is the commit message #2: > Fix nested subforms not getting correct name attribute on input fields. This is the commit message #3: > Fix subform rows having invalid index, fix small typo. This is the commit message #4: > Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process. This is the commit message #5: > Implement feedback from PR at Joomla; > - Use a <template> HTML element for the template of the subform rows, > not a url encoded string inside of a <script> element. > - Fix code style errors reported by phpcs. > - Make the fixing of the unique attributes (name, id, etc) of input elements > of nested subform rows more errorprone, using the same method as the main > subform row. > - Manually add a minified version of the javascript file. This is the commit message #6: > Fix failing javascript tests due to changed structure of subform repeatable template container. This is the commit message #7: > Change subform repeatable javascript test to correctly check on > 0-indexed rows, previously they have been 1-indexed. This is the commit message #8: > Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly. > Additionally added a note why the fixScripts() method is broken and how it could get better. * Commit code styling errors and add an aria label for the outermost 'add' button. * Fix double group-add button on repeatable subform type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the detail can be found in the commit messages.